remove container_name?

For discussion: Removing the `container_name` lines lets us run many ckan-docker sites at the same time (assuming you use different ports)

What is the benefit in forcing a container name in the docker compose config?
This commit is contained in:
Ian Ward 2023-09-26 17:10:23 -04:00 committed by GitHub
parent 6bbc482e0d
commit 2a8f844ecf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -8,7 +8,6 @@ volumes:
services: services:
ckan-dev: ckan-dev:
container_name: ${CKAN_CONTAINER_NAME}
build: build:
context: ckan/ context: ckan/
dockerfile: Dockerfile.dev dockerfile: Dockerfile.dev
@ -33,14 +32,12 @@ services:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:5000"] test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:5000"]
datapusher: datapusher:
container_name: ${DATAPUSHER_CONTAINER_NAME}
image: ckan/ckan-base-datapusher:${DATAPUSHER_VERSION} image: ckan/ckan-base-datapusher:${DATAPUSHER_VERSION}
restart: unless-stopped restart: unless-stopped
healthcheck: healthcheck:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8800"] test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8800"]
db: db:
container_name: ${POSTGRESQL_CONTAINER_NAME}
build: build:
context: postgresql/ context: postgresql/
environment: environment:
@ -60,7 +57,6 @@ services:
test: ["CMD", "pg_isready", "-U", "${POSTGRES_USER}", "-d", "${POSTGRES_DB}"] test: ["CMD", "pg_isready", "-U", "${POSTGRES_USER}", "-d", "${POSTGRES_DB}"]
solr: solr:
container_name: ${SOLR_CONTAINER_NAME}
image: ckan/ckan-solr:${SOLR_IMAGE_VERSION} image: ckan/ckan-solr:${SOLR_IMAGE_VERSION}
volumes: volumes:
- solr_data:/var/solr - solr_data:/var/solr
@ -69,8 +65,7 @@ services:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8983/solr/"] test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8983/solr/"]
redis: redis:
container_name: ${REDIS_CONTAINER_NAME}
image: redis:${REDIS_VERSION} image: redis:${REDIS_VERSION}
restart: unless-stopped restart: unless-stopped
healthcheck: healthcheck:
test: ["CMD", "redis-cli", "-e", "QUIT"] test: ["CMD", "redis-cli", "-e", "QUIT"]